Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5952: Add quickstart for ncf and ncf-builder #117

Merged
merged 1 commit into from
Dec 9, 2014

Conversation

VinceMacBuche
Copy link
Member

No description provided.

Title:Quickstart


In which we apply our first policy written in NCF.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitals police: ncf is always written "ncf", never with capitals.

@jooooooon
Copy link
Member

Guys, I've made many comments on this PR, but no feedback so far. What's going on? Who is working on this? @VinceMacBuche? @peckpeck?

@VinceMacBuche
Copy link
Member Author

Thanks for your feedback @jooooooon, I know @peckpeck has some things to modify. But I think it will be better if we add that so the pages are available and can be modified after

@jooooooon
Copy link
Member

Sorry @VinceMacBuche but I'm not happy publishing this until at least the typos and s/NCF/ncf/ have happened. Quality comes first, we can't publish a document which has obviously not been proof-read.

@VinceMacBuche
Copy link
Member Author

We may have misunderstand, I'm correcting everything than you tell me it's ok :) I can't agre more with you we can't publish with typo

@VinceMacBuche
Copy link
Member Author

I corrected quickstart and ncf-builder

@VinceMacBuche VinceMacBuche changed the title Add quickstart for ncf and ncf-builder Fixes #5952: Add quickstart for ncf and ncf-builder Dec 9, 2014
@@ -0,0 +1,53 @@
Tile: ncf-builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo here: should be Title

@jooooooon
Copy link
Member

Looks great! Just one typo to fix, then you can self-merge.

VinceMacBuche added a commit that referenced this pull request Dec 9, 2014
Fixes #5952: Add quickstart for ncf and ncf-builder
@VinceMacBuche VinceMacBuche merged commit f7205ea into Normation:master Dec 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants